lint: avoid false positives with custom errors-package #360

leonelquinteros · 2017-12-05T16:22:21Z

When using errors.New(fmt.Sprintf(...)),
lint will alert that you should use fmt.Errorf(...).

Before this patch, this alert was also displayed
when using a custom errors-package.
There are valid use cases to use errors.New(fmt.Sprintf(...))
in a custom errors-package context.

This patch avoids the "false positive" alert
when a custom errors-package is imported in the current file.

Fixes #350

andybons · 2018-02-21T20:09:17Z

@googlebot cla?

gopherbot · 2018-02-21T22:55:08Z

This PR (HEAD: 63c4d72) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/#/c/lint/+/96091 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2018-02-21T22:55:21Z

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/96091.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2018-02-28T22:39:51Z

Message from Andrew Bonventre:

Patch Set 1:

(3 comments)

This should have an associated test

Please don’t reply on this GitHub thread. Visit golang.org/cl/96091.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2018-03-01T01:02:52Z

This PR (HEAD: 70f7b1a) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/#/c/lint/+/96091 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2018-03-01T01:47:41Z

This PR (HEAD: 71ea537) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/#/c/lint/+/96091 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2018-03-01T01:48:29Z

Message from Leonel Quinteros:

Patch Set 2:

(3 comments)

Patch Set 1:

(3 comments)

This should have an associated test

Added a test case to cover the allowed cases when importing a custom errors package. The other cases are already covered in the test suite.

Please don’t reply on this GitHub thread. Visit golang.org/cl/96091.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2018-03-05T16:48:20Z

Message from Andrew Bonventre:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/96091.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2018-03-05T18:57:10Z

Message from Leonel Quinteros:

Patch Set 3:

Patch Set 3:

(1 comment)

Sorry, somehow the git commit --amend I did, created a new commit instead of updating the original message: cac6d06

Let me try to fix that.

Please don’t reply on this GitHub thread. Visit golang.org/cl/96091.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2018-03-05T19:16:53Z

This PR (HEAD: ec9d145) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/#/c/lint/+/96091 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2018-03-05T19:17:05Z

Message from Gerrit Bot:

Uploaded patch set 4: Commit message was updated.

Please don’t reply on this GitHub thread. Visit golang.org/cl/96091.
After addressing review feedback, remember to publish your drafts!

Fixes golang#350

…lint/+/96091 Updates golang#350

Updates golang#350

gopherbot · 2018-03-05T19:22:59Z

This PR (HEAD: 053e0ad) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/#/c/lint/+/96091 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2018-03-05T19:23:08Z

Message from Gerrit Bot:

Uploaded patch set 5: Commit message was updated.

Please don’t reply on this GitHub thread. Visit golang.org/cl/96091.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2018-03-05T19:28:55Z

Message from Andrew Bonventre:

Patch Set 5:

The commit message for a PR is determined from the title and first comment of the PR, not the commit message itself: https://github.com/golang/go/wiki/GerritBot#how-does-gerritbot-determine-the-final-commit-message

This is because there could be multiple commit messages in a PR, so it’s hard to determine which one should be used.

Please don’t reply on this GitHub thread. Visit golang.org/cl/96091.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2018-03-05T19:29:26Z

Message from Leonel Quinteros:

Patch Set 5:

Patch Set 3:

(1 comment)

OK, now i've rebased the branch, edited the commit messages and force-pushed the changes so it looks better to me.

Please don’t reply on this GitHub thread. Visit golang.org/cl/96091.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2018-03-05T19:32:28Z

Message from Leonel Quinteros:

Patch Set 5:

Patch Set 5:

The commit message for a PR is determined from the title and first comment of the PR, not the commit message itself: https://github.com/golang/go/wiki/GerritBot#how-does-gerritbot-determine-the-final-commit-message

This is because there could be multiple commit messages in a PR, so it’s hard to determine which one should be used.

Oh! Totally missed that. Thanks for the clarification. Quickly-editing right now.

Please don’t reply on this GitHub thread. Visit golang.org/cl/96091.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2018-03-05T19:33:17Z

Message from Gerrit Bot:

Uploaded patch set 6: Commit message was updated.

Please don’t reply on this GitHub thread. Visit golang.org/cl/96091.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2018-03-05T19:35:19Z

Message from Andrew Bonventre:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/96091.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2018-03-05T19:37:20Z

Message from Gerrit Bot:

Uploaded patch set 7: Commit message was updated.

Please don’t reply on this GitHub thread. Visit golang.org/cl/96091.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2018-03-05T19:39:18Z

Message from Andrew Bonventre:

Patch Set 7: Code-Review+1

(1 comment)

Ready for you, Alan.

Please don’t reply on this GitHub thread. Visit golang.org/cl/96091.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2018-03-05T19:41:39Z

This PR (HEAD: ad257d2) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/#/c/lint/+/96091 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2018-03-06T00:52:05Z

Message from Andrew Bonventre:

Patch Set 8:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/96091.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2018-03-06T13:05:33Z

Message from Gerrit Bot:

Uploaded patch set 9: Commit message was updated.

Please don’t reply on this GitHub thread. Visit golang.org/cl/96091.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2018-03-07T20:12:07Z

Message from Andrew Bonventre:

Patch Set 9: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/96091.
After addressing review feedback, remember to publish your drafts!

When using `errors.New(fmt.Sprintf(...))`, lint will alert that you should use `fmt.Errorf(...)`. Before this patch, this alert was also displayed when using a custom errors-package. There are valid use cases to use `errors.New(fmt.Sprintf(...))` in a custom errors-package context. This patch avoids the "false positive" alert when a custom errors-package is imported in the current file. Fixes #350 Change-Id: I7cc82a3435b184f8b4cad0752a75d44f33536dce GitHub-Last-Rev: ad257d2 GitHub-Pull-Request: #360 Reviewed-on: https://go-review.googlesource.com/96091 Reviewed-by: Andrew Bonventre <[email protected]>

gopherbot · 2018-03-07T20:12:13Z

This PR is being closed because golang.org/cl/96091 has been merged.

googlebot added the cla: yes label Feb 21, 2018

leonelquinteros added 3 commits March 5, 2018 16:22

lint: avoid false positives with custom errors-package

f3fbfb9

Fixes golang#350

lint: address code reviews from https://go-review.googlesource.com/c/…

28f5755

…lint/+/96091 Updates golang#350

lint: add test case to cover allowed errors.New(fmt.Sprintf()) cases

053e0ad

Updates golang#350

leonelquinteros force-pushed the master branch from ec9d145 to 053e0ad Compare March 5, 2018 19:22

leonelquinteros changed the title ~~Fix False positives with custom errors-package and errors.New(fmt.Spr…~~ lint: avoid false positives with custom errors-package Mar 5, 2018

lint: remove newline after code review

ad257d2

gopherbot closed this Mar 7, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

lint: avoid false positives with custom errors-package #360

lint: avoid false positives with custom errors-package #360

leonelquinteros commented Dec 5, 2017 •

edited

Loading

andybons commented Feb 21, 2018

gopherbot commented Feb 21, 2018

gopherbot commented Feb 21, 2018

gopherbot commented Feb 28, 2018

gopherbot commented Mar 1, 2018

gopherbot commented Mar 1, 2018

gopherbot commented Mar 1, 2018

gopherbot commented Mar 5, 2018

gopherbot commented Mar 5, 2018

gopherbot commented Mar 5, 2018

gopherbot commented Mar 5, 2018

gopherbot commented Mar 5, 2018

gopherbot commented Mar 5, 2018

gopherbot commented Mar 5, 2018

gopherbot commented Mar 5, 2018

gopherbot commented Mar 5, 2018

gopherbot commented Mar 5, 2018

gopherbot commented Mar 5, 2018

gopherbot commented Mar 5, 2018

gopherbot commented Mar 5, 2018

gopherbot commented Mar 5, 2018

gopherbot commented Mar 6, 2018

gopherbot commented Mar 6, 2018

gopherbot commented Mar 7, 2018

gopherbot commented Mar 7, 2018

lint: avoid false positives with custom errors-package #360

lint: avoid false positives with custom errors-package #360

Conversation

leonelquinteros commented Dec 5, 2017 • edited Loading

andybons commented Feb 21, 2018

gopherbot commented Feb 21, 2018

gopherbot commented Feb 21, 2018

gopherbot commented Feb 28, 2018

gopherbot commented Mar 1, 2018

gopherbot commented Mar 1, 2018

gopherbot commented Mar 1, 2018

gopherbot commented Mar 5, 2018

gopherbot commented Mar 5, 2018

gopherbot commented Mar 5, 2018

gopherbot commented Mar 5, 2018

gopherbot commented Mar 5, 2018

gopherbot commented Mar 5, 2018

gopherbot commented Mar 5, 2018

gopherbot commented Mar 5, 2018

gopherbot commented Mar 5, 2018

gopherbot commented Mar 5, 2018

gopherbot commented Mar 5, 2018

gopherbot commented Mar 5, 2018

gopherbot commented Mar 5, 2018

gopherbot commented Mar 5, 2018

gopherbot commented Mar 6, 2018

gopherbot commented Mar 6, 2018

gopherbot commented Mar 7, 2018

gopherbot commented Mar 7, 2018

leonelquinteros commented Dec 5, 2017 •

edited

Loading